-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement YouTube Audio File Search Function #70
Labels
feature
Implemented a new feature
Comments
3 tasks
antonplagemann
added
needs assignee
This issue needs someone to solve
feature
Implemented a new feature
labels
Feb 26, 2022
antonplagemann
changed the title
Implement a function that takes a youtube link, extracts the youtube id and finds the correct audio file (ogg vorbis is preferred)
Implement YouTube Audio File Search Function
Feb 26, 2022
2 tasks
/cib |
Branch feature/70-Implement-YouTube-Audio-File-Search-Func created! |
Simon-Walz
added a commit
that referenced
this issue
Mar 19, 2022
* Create draft PR for #70 * work in progress * add full url-finder functionality, still lacking error handling, typing and security * add interfaces for typing, add basic error handling * more error handling * removed log statements * add more error handling, move audio file finder construction to full finder constructor * add error handling enum and named-error generator * add tsdoc comments, slight refactoring for reusability, moved class out of mod.ts * add unit test files and first unit tests for error generator * added more unit testing * add private access modifier to attributes * add more unit testing * switched to single quotes * add more unit testing * cleanup lib/youtube-audio-url-finder/mod.ts * fix formatting * fix import map * fix fishing slash import map entry * Added lib folder to deno.json for formatting * add more unit testing * Update backend/lib/youtube-audio-url-finder/youtube-audio-url-finder.ts Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Update backend/lib/youtube-audio-url-finder/youtube-audio-url-finder.ts Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Update backend/lib/youtube-audio-url-finder/youtube-audio-url-finder.ts Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Update backend/lib/youtube-audio-url-finder/invidious-instance-finder.ts Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Update backend/lib/youtube-audio-url-finder/audio-file-url-finder.ts Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Update backend/lib/youtube-audio-url-finder/audio-file-url-finder.ts Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Apply suggestions from code review Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Update backend/lib/youtube-audio-url-finder/audio-file-url-finder.ts Co-authored-by: Philipp Fruck <dev@p-fruck.de> * Apply suggestions from code review Co-authored-by: Philipp Fruck <dev@p-fruck.de> * fix import map * fix formatting * add more unit tests * added messages to unit tests * Apply suggestions from code review Co-authored-by: Philipp Fruck <dev@p-fruck.de> Co-authored-by: Simon-Walz <Simon-Walz@users.noreply.github.com> Co-authored-by: Simon-Walz <57764295+Simon-Walz@users.noreply.github.com> Co-authored-by: Pius Walter <pius.walter@gmx.net> Co-authored-by: Philipp Fruck <dev@p-fruck.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Implement a function that takes a youtube link, extracts the youtube id and finds the correct audio file (ogg vorbis is preferred).
🟢 In scope:
🔴 Not in scope:
What should be the result?
A functions that takes a youtube url and returns a link the the corresponding audio file.
The text was updated successfully, but these errors were encountered: