Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to MPD systemd service file? #124

Closed
ArchangeGabriel opened this issue Oct 7, 2017 · 2 comments
Closed

Changes to MPD systemd service file? #124

ArchangeGabriel opened this issue Oct 7, 2017 · 2 comments

Comments

@ArchangeGabriel
Copy link

Hi,

I’ve recently realized that if MPD is built without systemd-daemon support (which, according to the configure script, is for socket activation), the Type=notify makes the service useless because it apparently doesn’t support notify in this case. Changing to simple (or removing the line altogether since this is the default). I understand per #121 that you want to keep notify, so I’m only proposing to remove that when compiling without systemd-daemon. Or change the configure script so that systemd-daemon support is said mandatory for systemd support and do not allow to package systemd units files without it.

Looking at the service file, I realized that some more changes could be made depending on the compilation options:

  • if compiling without network support, maybe network.target and AF_INET AF_INET6 AF_NETLINK should be removed.
  • if compiling without IPv6 support, removing only AF_INET6?

Thanks.
@ArchangeGabriel ArchangeGabriel mentioned this issue Oct 7, 2017
Closed
@MaxKellermann
Copy link
Member

I consider it useless to use MPD with systemd without compiling it with libsystemd. It is not a supported use case.

@ArchangeGabriel
Copy link
Author

OK. What about units changes regarding network support?

mbakke pushed a commit to guix-mirror/guix that referenced this issue Feb 11, 2019
@lfam
gnu: MPD: Update to 0.21.4.
f52bd82 
We no longer install any systemd unit files for MPD because this is no longer
supported upstream as a matter of policy or via MPD's build system. [0]

Specifically, they don't support using MPD with systemd unless MPD was linked
with libsystemd. The unit files are only built when this is the case.

[0]
<MusicPlayerDaemon/MPD#124 (comment)>

* gnu/packages/mpd.scm (mpd): Update to 0.21.4.
[build-system]: Use meson-build-system.
[native-inputs]: Add gcc-8, gcc-8:lib, and python-sphinx.
[arguments]: Add a 'expand-C++-include-path' phase. Remove the
'install-service-files' phase. Make sure to build the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArchangeGabriel @MaxKellermann