Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of SACD ISO images in mpd #644

Closed
mistepien opened this issue Sep 13, 2019 · 1 comment
Closed

Support of SACD ISO images in mpd #644

mistepien opened this issue Sep 13, 2019 · 1 comment

Comments

@mistepien
Copy link

Feature request

It would be great to merge code or functionality from:
https://github.com/archphile/mpd-manisiutkin

This is about supporting the SACD iso images.

@MaxKellermann
Copy link
Member

This repository cannot be merged for formal reasons, because it isn't a fork of the MPD git repository - it doesn't contain any commits which can be merged, technically. Any changes in the code would need to be identified manually and copied manually. No, thanks.

But I happen to know this MPD fork. The author tried to get the feature merged into MPD many years ago, but his code failed the review. Instead of fixing it, he decided to continue to maintain his code as an independent fork. Now it's many years later, the code is still in extremely bad shape, and still doesn't meet the quality requirements to be merged into the MPD repository.

This kind of feature would be useful for MPD, but there appears to be nobody willing to do it properly. Pull request welcome for good code, but this is not. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants