-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/output: add algorithm for finding usable AudioFormat #1014
src/output: add algorithm for finding usable AudioFormat #1014
Conversation
Can you split this commit, so I can cherry-pick the fix for the stable branch? |
d1855a2
to
d74dd52
Compare
d74dd52
to
27a6764
Compare
27a6764
to
cdaa3d5
Compare
Sorry for letting you wait for so long, and thanks for putting so much work into splitting the PR. I don't want to use pthread emulation for MPD/Windows builds, so I'll try to figure out how to do it without those C++ threading features. And I'll try to backport the format detection code to the stable branch without the threading changes. This is the most important change here. Meanwhile, I've cherry-picked a few trivial commits. It would be great if you could keep your PR branch rebased on my master branch. |
* Use PcmExport for 24bit packed output
cdaa3d5
to
c352b73
Compare
* change `ComWorker` to use `Future` and `Promise`
I've implemented std::future and std::promise for mingw32 without pthread. |
Cherry-picked to v0.22 with some cleanups |
See #967