Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on FreeBSD #22

Closed
wants to merge 2 commits into from
Closed

Fix build on FreeBSD #22

wants to merge 2 commits into from

Conversation

ephemeralriggs
Copy link
Contributor

Two patchsets are required to make mpd build successfully on FreeBSD. These are likely issues on other platforms as well.

  • src/util/VarSize.hxx requires cstdlib to be included to use free() . Probably on Linux this is pulled in via some other header and hence complies.
  • During the overhaul of the DB methods, several method signatures no longer match the corresponding types in Interface.hxx. clang36 on FreeBSD-10 refuses to auto-convert the 'static bool' methods to the required 'void' and exits.

@MaxKellermann
Copy link
Member

Cherry-picked into v0.20.x (stable)

@ephemeralriggs ephemeralriggs deleted the freebsd branch February 26, 2017 08:25
@sss123next sss123next mentioned this pull request Aug 9, 2017
Closed
@fajard01 fajard01 mentioned this pull request Sep 6, 2017
Closed
@mistepien mistepien mentioned this pull request Jan 29, 2018
Closed
@github1299 github1299 mentioned this pull request Aug 9, 2018
Closed
@kaifisher kaifisher mentioned this pull request Dec 18, 2019
Closed
@avuton avuton mentioned this pull request Oct 28, 2020
Closed
Rio6 pushed a commit to Rio6/MPD that referenced this pull request May 12, 2021
@arcnmx
ytdl: check exit code before completing json parse
b9c4a4e 
When youtube-dl fails, it exits with an error code and prints an error
message on stderr, writing nothing to stdout. This resulted in a yajl
"unexpected EOF" error, which is unhelpful to users.

Fixes MusicPlayerDaemon#22
@bishonenknife bishonenknife mentioned this pull request Sep 2, 2022
Closed
@lordoff lordoff mentioned this pull request Oct 3, 2022
Closed
@whatamesss whatamesss mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ephemeralriggs @MaxKellermann