meson: do not require rsync to build #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to mesonbuild/meson#8641 the latest versions of meson now check that the first argument to run_target is a found executable. This causes rsync to become explicitly required even though it is only used for maintainer targets... there are essentially 3 solutions: - explicit find_program and only define the target if rsync is found - explicit find_program with a disabler that auto-disables the target if not found - run the program "env rsync", since env is basically always available and will in turn run rsync -- but meson doesn't know that rsync is "needed" Options 1 and 2 conveniently hide the maintainer target from people who do not care, and the disabler is slightly shorter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to mesonbuild/meson#8641 the latest versions of meson now check that the first argument to run_target is a found executable.
This causes rsync to become explicitly required even though it is only used for maintainer targets... there are essentially 3 solutions:
not found
and will in turn run rsync -- but meson doesn't know that rsync is
"needed"
Options 1 and 2 conveniently hide the maintainer target from people who do not care, and the disabler is slightly shorter.
Fixes #101