This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
Merge go-ethereum updates into 2.5.2 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis: bump Android NDK version and Android Go builder
build: enable gofmt and misspell linters
This changes behaviour: before if the owner/amount didn't match, it resulted in a successful execution without doing anything; now it results in a failed execution using the revert opcode (remainder gas is not consumed).
Fixes #15373
* build: enable unconvert linter - fixes #15453 - update code base for failing cases * cmd/puppeth: replace syscall.Stdin with os.Stdin.Fd() for unconvert linter
github.com/stretchr/testify is a useful library for doing assertion in tests. It makes assertions in test more less verbose and more comfortable to read and use.
…e (#15458) * .dockerignore, internal/build: Read git information directly from file This commit changes the way of retrieving git commit and branch for build environment from running git command to reading git files directly. This commit also adds required git files into Docker build context. fixes: #15346 * .dockerignore: workaround for including some files in .git
* cmd/puppeth: handle encrypted ssh keys * cmd/puppeth: fix unconvert linter error
dockerignore, internal/build: forward correct git folder
vendor: add github.com/stretchr/testify test dependency
Dockerfile: support alltools image beside plain Geth
core/vm: fix typos in jump_table.go
* accounts, internal: return an error if no suitable estimated gas found * accounts, internal: minor polishes on the gas estimator
* cmd, dashboard: dashboard using React, Material-UI, Recharts * cmd, dashboard, metrics: initial proof of concept dashboard * dashboard: delete blobs * dashboard: gofmt -s -w . * dashboard: minor text and code polishes
core: split same-td blocks on block height
core/vm: improve jumpdest analysis
core/bloombits: handle non 8-bit boundary section matches
|
@immartian Please review. |
|
@5chdn Sorry for the delay, will get this merged soon! |
|
tested |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes since v2.5.2 include: