Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quest UnusedConditions #413

Closed
Elscrux opened this issue Jan 29, 2023 · 0 comments
Closed

Quest UnusedConditions #413

Elscrux opened this issue Jan 29, 2023 · 0 comments
Labels
api enhancement skyrim

Comments

@Elscrux
Copy link
Member

Elscrux commented Jan 29, 2023

Skyrim's quests have this field UnusedConditions which is actually used for conditions applied via story manager event nodes. It should be called something like EventConditions instead imo.

See https://en.uesp.net/wiki/Skyrim_Mod:Mod_File_Format/QUST

xEdit apparently didn't know that https://github.com/TES5Edit/TES5Edit/blob/dev-4.1.5/Core/wbDefinitionsTES5.pas#L11611
Elscrux added a commit to Elscrux/Mutagen that referenced this issue Feb 13, 2023
@Elscrux
Renamed UnusedConditions to EventConditions as described in Mutagen-M…
15e7161 
…odding#413
Noggog added a commit that referenced this issue Feb 17, 2023
@Noggog
Merge pull request #416 from Elscrux/dev
7e7e2c5 
Renamed UnusedConditions to EventConditions as described in #413
@Noggog Noggog closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement skyrim
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Noggog @Elscrux