Store Nostr Wallet Connect Events #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes blastr store nostr wallet connect events so we can use them without having to worry about them being epheremeral.
TonyGiorgio
approved these changes
May 26, 2023
There was a problem hiding this comment.
Nice work, looks good just some nits.
I'm a bit concerned about the consistency with putting lists KV store but it's zaps who cares. And theres nothing that makes sure these ephemeral events don't eventually get deleted but we can manually delete occasionally when it gets too big. In fact we can probably do that for "published" events KV store if we wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes blastr store nostr wallet connect events so we can use them without having to worry about them being epheremeral.