Add public and private zaps

[benthecarman]

This was almost very simple, but sadly doing private zaps with a NIP-07 extension isn't very well supported. The way clients generate the random npub is deterministic from the user's nsec, but since we don't have the user's nsec, we cannot do this. Private zaps will still work, we can just randomly generate the key, the problem is if we see the event in the future, we won't be able to decrypt it ourselves.

[TonyGiorgio]

the problem is if we see the event in the future, we won't be able to decrypt it ourselves.

We'll still have some reference for it inside of mutiny, right? And for private zaps, the receiver will still see it was from the sender?

[benthecarman]

We'll still have some reference for it inside of mutiny, right?

Not unless we want to persist the key and which event it is associated with

And for private zaps, the receiver will still see it was from the sender?

yes they can tell

the main drawback is if I do a private zap Ben -> Tony, if I open up in Damus I will see you were private zapped but won't be able to tell it was mine. For the receiver it will all be normal though

[TonyGiorgio]

if I do a private zap Ben -> Tony, if I open up in Damus I will see you were private zapped

That's fine IMO, I don't care that much if we're limited here. But will it still show up in Mutiny is more my question.

[benthecarman]

That's fine IMO, I don't care that much if we're limited here. But will it still show up in Mutiny is more my question.

yes, because we save the info locally

[TonyGiorgio]

needs rebase

[benthecarman]

New release of rust-nostr came out so was able to simplify