Support new NWC commands

[benthecarman]

This adds support for get_balance, get_info, make_invoice, and lookup_invoice.

Currently missing the multi commands as they'd require a larger refactor that I'd rather do as a follow up. Also left out keysends because that'd require a refactor for budgeting and list_transactions because I am not sure how we'd want to implement that while preserving privacy.

Closes #895

[TonyGiorgio]

needs rebase

[TonyGiorgio]

Failing tests

[TonyGiorgio]

needs rebase

[TonyGiorgio]

This adds support for get_balance, get_info, make_invoice, and lookup_invoice.

These should probably be allowed by default

[benthecarman]

These should probably be allowed by default

Done

[rolznz]

Cool! How can I test this? do I need to create a new connection? I tried to create one and get "Unknown error occurred" - auto approve, 10000 sats, resets daily

[benthecarman]

This hasn't been deployed yet, should be by the end of the month

[rolznz]

I tried the Mutiny latest update (PWA version) and am still having issues doing any requests outside of pay_invoice. Is it in this release?

I would love to see Mutiny working with some of the NWC-powered apps like the BuzzPay PoS https://github.com/getAlby/pos

[benthecarman]

If you make a new connection it should get the new commands.

[rolznz]

I tried again today. make_invoice works, but lookup_invoice never seems to be updated so the PoS never gets a confirmation of the payment (it polls lookup_invoice). My mutiny wallet was open and I received the payment there.

I updated the PoS to be more relaxed and will show a confirmation rather than erroring if the wrong NWC permissions are given. You should be able to try it: https://github.com/getAlby/pos

[benthecarman]

In the logs I am getting these errors after it is paid, seems like something on your end, that error message isn't from us

[rolznz]

@benthecarman that error happens when we get no reply from the wallet within a timeout. Can you check the reply payload you are sending?

[benthecarman]

looks like the lookup invoice doesn't have any parameters, I am getting this error in mutiny No payment_hash or bolt11 provided

[benthecarman]

hmm looks like rust-nostr is parsing for bolt11 but the spec is invoice 🤦‍♂️ my bad. If you guys switch it to the use the payment_hash it should probably work