lightning-liquidity alpha release
#1050
Conversation
mutiny-core/src/lsp/lsps.rs
Outdated
| @@ -355,7 +344,7 @@ impl<S: MutinyStorage> Lsp for LspsClient<S> { | |||
| // this is only here to keep both voltage + lsps logic symmetric | |||
| if inbound_capacity_msat >= fee_request.amount_msat { | |||
| return Ok(FeeResponse { | |||
| id: None, | |||
| id: String::from("deadbeef"), | |||
There was a problem hiding this comment.
pretty sure this is wrong lol
There was a problem hiding this comment.
it's not actually :)
we aren't using the flow in this case. if they have liquidity we want to just generate a regular invoice and not use lsps.
so instead of returning some kind of Error here, to keep the flows symmetric it just returns nonsense response that won't get used
There was a problem hiding this comment.
but does have me wondering why we even have to enter the flow, let me review and remind myself
There was a problem hiding this comment.
seems like it can be refactored out, let me try
There was a problem hiding this comment.
ok, removed the fee check when user has enough inbound liquidity on lsps flow
|
Not able to create an invoice on mutinynet with this branch, just hangs |
what token are you using, lspstoken doesn't exist anymore :( try with: 4GH1W3YW though we are also having issues testing with ldk-node where the channel opens but htlc is never forwarded.. looking into that separately. but you should be able to get an invoice |
|
Is there anything we can do to log that the token is invalid? |
that doesn't seem to work either :/ |
I need to run for a bit but yes there should be. we return (and the spec specifies) an error code for this. just need to double check how the client surfaces it (if it does) |
Can you try again we just deployed a couple fixes. What payment size are you trying? Anything helpful in logs? |
|
Trying on signet for 100k sats and still failing, nothing in the logs |
johncantrell97
force-pushed
the
lsps-alpha
branch
from
3d74b75
to
82aba79
Compare
* specify payment size with buy request * upgrade to liquidity alpha release crate * remove fee check when user liquidity * fix request ids
This PR:
liquiditylibrary to pass payment_size_msat toselect_opening_paramsliquiditylibrary.There is no longer the need (or ability) to use a
user_channel_idwith the LSPS flow. It actually introduces a library generatedRequestIdthat is returned when a request is made. This can be used exactly like the voltage flowfee_id. Allowed for some simplification by removing all usage of user_channel_id and remove theOptionon both FeeResponseidand InvoiceRequestfee_id. Both flows use this id now.