Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt payments before on chain syncing #1056

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

benthecarman
Copy link
Collaborator

Closes #1055

Adds an AtomicBool that we have synced this session. Not using the one in storage because we should check every new startup.

Also noticed that we did not have all of our initial send logic for keysends so copied it over.

@benthecarman benthecarman added bug Something isn't working LDK labels Mar 7, 2024
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to be reproduced and tested.

mutiny-core/src/nodemanager.rs Show resolved Hide resolved
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trusting that you reproduced and tested this first before merging.

@benthecarman benthecarman merged commit 497aa05 into master Mar 9, 2024
9 checks passed
@benthecarman benthecarman deleted the sync-b4-send branch March 9, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working LDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't attempt payments before on chain syncing
2 participants