Show in-flight fedimint sends #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MutinyWallet#1022 Right after the payment has initiated successfully, and before persisting the invoice, set its status to InFlight, so it doesn't get filtered out in the activity list.
TonyGiorgio
reviewed
Mar 8, 2024
| @@ -560,6 +560,7 @@ impl<S: MutinyStorage> FederationClient<S> { | |||
| let mut stored_payment: MutinyInvoice = invoice.clone().into(); | |||
| stored_payment.inbound = inbound; | |||
| stored_payment.labels = labels; | |||
| stored_payment.status = HTLCStatus::InFlight; | |||
There was a problem hiding this comment.
nice catch. Though we don't typically use InFlight much, just wondering if it was Pending before and was being filtered out for whatever reason, or really why InFlight is used at all.
There was a problem hiding this comment.
Pending is what we use for invoices we create that are unpaid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1022
Right after the payment has initiated successfully, and before persisting the invoice, set its status to InFlight, so it doesn't get filtered out in the activity list.