Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mint discoverability #1060

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Mint discoverability #1060

merged 2 commits into from
Mar 25, 2024

Conversation

benthecarman
Copy link
Collaborator

basic implementation of: nostr-protocol/nips#1110

we should probably also add support for creating a recommendation event for federations we've joined

@benthecarman benthecarman mentioned this pull request Mar 8, 2024
Merged
@benthecarman benthecarman force-pushed the mint-discoverability branch 2 times, most recently from 07111c5 to cccc1ee Compare March 8, 2024 23:32
@benthecarman benthecarman mentioned this pull request Mar 11, 2024
Merged
TonyGiorgio
TonyGiorgio requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the primal commit needs to be fixed and merged first

mutiny-core/src/nostr/mod.rs Outdated Show resolved Hide resolved
@TonyGiorgio
Copy link
Contributor

needs rebase

@benthecarman benthecarman force-pushed the mint-discoverability branch 2 times, most recently from aa1fc06 to 1d01bf0 Compare March 12, 2024 18:29
@benthecarman
Copy link
Collaborator Author

Implemented so now we check against primal's list of trusted users.

Made it so we can see recommended federations even if they haven't announced themselves on nostr

Added the ability to recommend federations.

TonyGiorgio
TonyGiorgio requested changes Mar 12, 2024
View reviewed changes
mutiny-core/src/nostr/mod.rs Show resolved Hide resolved
mutiny-core/src/nostr/mod.rs Outdated Show resolved Hide resolved
mutiny-core/src/nostr/mod.rs
vec![invite_code.to_string(), "fedimint".to_string()],
);

// todo tag the federation announcement event, to do so we need to have the pubkey of the federation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't really possible?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to save the pubkey of it when we add it from recommendations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unsure how this is supposed to work and link together. Is it just by the d_tag being the same across reviews? Does the federation invite code even need to be here? Should we pull down the other federation members invite code's to put in the vec?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just by the d_tag being the same across reviews?

Yeah the d tag is the federation id

Does the federation invite code even need to be here?

Yeah, in the case the federation has not announced itself

Should we pull down the other federation members invite code's to put in the vec?

We could... I figured since it is a recommendation, they recommend the code they are using, maybe that is the most reliable member in the federation.

mutiny-core/src/nostr/mod.rs Outdated Show resolved Hide resolved
mutiny-core/src/nostr/primal.rs Outdated Show resolved Hide resolved
@benthecarman benthecarman force-pushed the mint-discoverability branch 4 times, most recently from 87ae5bc to bb42fae Compare March 20, 2024 23:46
@TonyGiorgio
Copy link
Contributor

Also, is this up to date with the latest of the spec?

@benthecarman
Copy link
Collaborator Author

Also, is this up to date with the latest of the spec?

Yeah

@benthecarman
Copy link
Collaborator Author

rebased

@benthecarman benthecarman merged commit 7165132 into master Mar 25, 2024
9 checks passed
@benthecarman benthecarman deleted the mint-discoverability branch March 25, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
fedimint nostr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benthecarman @TonyGiorgio