Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for NWA #1061

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fixes for NWA #1061

merged 1 commit into from
Mar 19, 2024

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Mar 9, 2024

Cleaned up some code while I was at it. Main things that fixed the issue was broadcasting the auth event to all of our relays and not putting the relay in the auth event when it wasn't needed.

This fixes when I was able to reproduce with zapple-pay, not sure if it fixes with nostr.wine @nostr-wine, should it send me an invoice right away?

Closes #1057

@benthecarman benthecarman added bug Something isn't working nostr labels Mar 9, 2024
@nostr-wine
Copy link

nostr-wine commented Mar 9, 2024

Same issue testing for me.

Connection Event ID: 21020f1b151bc9ca70477acc1440d6bc7ef37107c7f365e60208db406549fcbf
Wallet pubkey: a6f327a3c1b6ab97b891940fc7c54f90c7717af3380d200875a854a1f7590f7f

pay_invoice IDs: 0441906fc6d12fdeb6c12dac24dc7fcbe380dbc851310615e244140f45e4886b, 77b1a102178d02e647c041d29d48066a96d8b14769accde6c852ed1833cd5b2d, cb1b61d2bdd20331839e447d1b9c6e35b882f17f1e217f1df80355d7379fe8ef

EDIT: I just sent your pubkey one now as well if its helpful. ID is f38949e5d67b3d12031b5b311172a961e792ef5051da26d9963b1799e3b467fe

@@ -124,6 +126,7 @@ impl<S: MutinyStorage> NostrManager<S> {
// add relays for default sending
relays.push("wss://nostr.mutinywallet.com".to_string()); // blastr
relays.push("wss://relay.mutinywallet.com".to_string()); // strfry
relays.push(DEFAULT_RELAY.to_string()); // add in case it's not in the list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're pushing the same thing twice.

@TonyGiorgio
Copy link
Contributor

Same issue testing for me.

Connection Event ID: 21020f1b151bc9ca70477acc1440d6bc7ef37107c7f365e60208db406549fcbf Wallet pubkey: a6f327a3c1b6ab97b891940fc7c54f90c7717af3380d200875a854a1f7590f7f

pay_invoice IDs: 0441906fc6d12fdeb6c12dac24dc7fcbe380dbc851310615e244140f45e4886b, 77b1a102178d02e647c041d29d48066a96d8b14769accde6c852ed1833cd5b2d, cb1b61d2bdd20331839e447d1b9c6e35b882f17f1e217f1df80355d7379fe8ef

EDIT: I just sent your pubkey one now as well if its helpful. ID is f38949e5d67b3d12031b5b311172a961e792ef5051da26d9963b1799e3b467fe

Nothing would have changed server side with this PR. This is on the wallet, so it wouldn't be fixed for you unless you recompiled mutiny-node and imported it into your own instance of mutiny-web.

If @benthecarman can fix the minor PR feedback change, we can deploy this in the next few weeks for you to test again.

@TonyGiorgio
Copy link
Contributor

needs rebase

Cleaned up some code while I was at it. Main things that fixed the issue
was broadcasting the auth event to all of our relays and not putting the
relay in the auth event when it wasn't needed.
@TonyGiorgio TonyGiorgio merged commit 040e037 into master Mar 19, 2024
9 checks passed
@TonyGiorgio TonyGiorgio deleted the nwa-fix branch March 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nostr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NWA Connection Issue
3 participants