Follow and Unfollow nostr contacts #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
reviewed
Mar 20, 2024
TonyGiorgio
approved these changes
Mar 20, 2024
benthecarman
changed the title
benthecarman
force-pushed
the
follow-unfollow
branch
from
2053cbf
to
24d232a
Compare
|
Did some code clean up and ended up doing the mutex just to be safe. |
TonyGiorgio
reviewed
Mar 20, 2024
benthecarman
force-pushed
the
follow-unfollow
branch
2 times, most recently
from
a852654
to
5722de4
Compare
|
Added |
benthecarman
force-pushed
the
follow-unfollow
branch
from
5722de4
to
95cd80d
Compare
futurepaul
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1068
This has the base functionality needed for following and unfollowing. Tried to do my best to prevent us from deleting a follow list.
One thing with this is there is potential race conditions if you call follow/unfollow in rapid succession. Could add a mutex around adding follows but that feels a little overkill, maybe will have to bite the bullet though@futurepaul I imagine you'll want some extra utility around this. I was thinking of adding
is_followedtoTagItem. Is there anything else I could add that you can think of?