Fix LSP connection failures during maintance #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065
First commit adds a bunch of logging for us
Second commit fixes an issue i discovered while debugging. If we changed the LSP env variable then it'd set the lsp in the user's config to
null. This would cause problems if we ever changed the default LSP as then it would break people's old wallets.Third commit fixes the root issue, was a bug from #1018 where all the optimizations I did weren't being fully utilized because we weren't using the saved LSP config but preferring the one from env variables which did not have the connection info so we'd have to refetch it.
For simulating the LSP being down I added another domain for the lsp
signet-lsp.mutinynet.comand would change the proxy pass port when I wanted it to be down