Use lightning-net-tokio for non-wasm builds #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet, waiting for @elnosh to say everything is working for him with this |
benthecarman
force-pushed
the
fix-std-net
branch
from
7aaf21c
to
b3ea395
Compare
|
Thanks for the help here. It fixed some of the problems I was having but still running into some intermittent issues while starting the server so I wouldn't merge this yet. I'll keep testing this |
benthecarman
force-pushed
the
fix-std-net
branch
3 times, most recently
from
c2173db
to
f1afede
Compare
benthecarman
changed the title
|
Was still getting issues so just switched to using |
benthecarman
force-pushed
the
fix-std-net
branch
from
f1afede
to
a0c7111
Compare
|
I've been trying now with your changes using |
TonyGiorgio
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was helping @elnosh with getting networking working for mutiny-server
tried a bunch of things and gave up, just using
lightning-net-tokioinstead of rolling our own network impl for server context