Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for blind tokens #1085

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fixes for blind tokens #1085

merged 1 commit into from
Mar 26, 2024

Conversation

benthecarman
Copy link
Collaborator

  • We couldn't ever write the tokens to storage because it was trying to use ServicePlanIndex as a key for the json object. Json object's keys need to be strings so I manually implemented serde for it doing it just as x-y
  • Added implementation for reading tokens from VSS

@benthecarman benthecarman added the bug Something isn't working label Mar 26, 2024
TonyGiorgio
TonyGiorgio approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it was better to leave it as (u32, u32) but I guess this works too.

@TonyGiorgio
Copy link
Contributor

broken tests

@benthecarman
Copy link
Collaborator Author

I still think it was better to leave it as (u32, u32) but I guess this works too.

I think that would have the same issue, doesn't encode to a string

@TonyGiorgio TonyGiorgio merged commit 1708d95 into master Mar 26, 2024
9 checks passed
@TonyGiorgio TonyGiorgio deleted the blind-auth-followup branch March 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benthecarman @TonyGiorgio