Hermes Tests #1158
Merged
Hermes Tests #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
approved these changes
Apr 26, 2024
|
Needs rebase |
benthecarman
force-pushed
the
hermes-tests
branch
from
1f79219
to
2ff62a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a small refactor so testing the hermes claiming is simpler, just moving some code into its own function.
Otherwise adds a bunch of tests for handling zaps from hermes. Did find a niche bug with private zaps and using a NIP-07 extension, it would mark it as public when we couldn't decrypt instead of marking as Anon.
Wanted to add registration tests but might be easier to wait for when we support free addresses as the paid tests would make it 1000x more complex
Part of #1093