Await funding transaction on open channel #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft, seems if our counter party rejects the channel we get a |
benthecarman
force-pushed
the
await-funding-txo
branch
from
eea991b
to
eed18a4
Compare
benthecarman
force-pushed
the
await-funding-txo
branch
from
eed18a4
to
aeec595
Compare
|
Ready for review |
TonyGiorgio
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #375 but for channels.
Was able to take this logic from redshifts and make the
open_channelfunctions better. Now they will await the funding transaction being created, this should give better feedback to the frontend if the channel open actually worked.