Retry spendable outputs individually #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
reviewed
Jul 18, 2023
mutiny-core/src/node.rs
Outdated
| let _ = event_handler.handle_spendable_outputs(&[o.clone()]).await; | ||
| } | ||
| }; | ||
| persister.clear_failed_spendable_outputs()?; |
There was a problem hiding this comment.
Why clear them when they failed?
| Err(e) => log_warn!(logger, "Failed to retry spendable outputs {e}"), | ||
| Err(_) => { | ||
| // retry them individually then delete | ||
| // if there was only one we don't need to retry |
There was a problem hiding this comment.
We were batching them all together, if one has already been swept but one not, then the whole thing would fail. This should help prevent that.
benthecarman
force-pushed
the
better-retry
branch
from
f464c77
to
1347b45
Compare
TonyGiorgio
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might help with missed swept force closes