-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move VSS into mutiny-core #669
Conversation
77607d9
to
e2ba86a
Compare
I should write tests |
Didn't work when I restored from a wallet with a password on it.
|
e2ba86a
to
fb05a30
Compare
Tested and was able to do the full flow. There is only one "bad" case now, if you recover without every opening the wallet since this update to get the migration, then you'll get the monitors but not the manager, in this case you'll have a 0 lightning balance which is a little scary but if the channels are force closed you'll get your money back. Maybe along with this we can add a force close channels button in the settings that'll reuse some of our scb stuff to tell the LSP to close the channel. |
rebased onto master, testing now. |
I've tested this multiple times now and keep running into storage problems that causes the whole thing to not load.
Irrecoverable state:
|
a17c946
to
8379b64
Compare
@TonyGiorgio fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a lot of different paths and upgrades, works pretty well, nice job!
Closes #652
To fix the backwards compatibility I had to change the channel monitor encoding (luckily we wanted to get this to hex). This should make it so worst case that if a user with a password never opens to get the the update, they will get a restore with a force close.
We should heavily test this