Encryption password UX #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
07f839d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://85ebde16.mutiny-web.pages.dev |
| Branch Preview URL: | https://issue490.mutiny-web.pages.dev |
benalleng
force-pushed
the
issue490
branch
2 times, most recently
from
31af0b4
to
41aba8e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
futurepaul
reviewed
Aug 28, 2023
benalleng
force-pushed
the
issue490
branch
4 times, most recently
from
3419331
to
447d302
Compare
|
Upon learning how modular forms works more, I don't think createEffect is a good route afterall, the standard validate after submitting is sufficient. It continuosly checks on its own after submitting once already. |
futurepaul
requested changes
Sep 20, 2023
| createForm<EncryptPasswordForm>({ | ||
| initialValues: { | ||
| existingPassword: "", | ||
| password: "", | ||
| confirmPassword: "" | ||
| }, | ||
| validate: (values) => { | ||
| setError(undefined); |
There was a problem hiding this comment.
makes more sense to put this in handleFormSubmit because that's where the setter happens
There was a problem hiding this comment.
Just tried this, but I remembered why its here, we need the error to reset on any change to the form and not only on submit since an error prevents the user from submitting.
There was a problem hiding this comment.
Due to the encryptButtonDisabled the encrypt button is unclickable until the user has made a change to any of the forms
benalleng
force-pushed
the
issue490
branch
2 times, most recently
from
0d1ae85
to
d8e7d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #490 after Mutiny-node/#727 is merged
Adds similar logic to prevent #462 from cropping up here