Nostr activity and tag support #534
Conversation
benalleng
force-pushed
the
nostr-enhancement
branch
from
ef883cd
to
9912705
Compare
Deploying with
|
| Latest commit: |
c6da807
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00fe5443.mutiny-web.pages.dev |
| Branch Preview URL: | https://nostr-enhancement.mutiny-web.pages.dev |
benalleng
force-pushed
the
nostr-enhancement
branch
2 times, most recently
from
f36700c
to
8b1538f
Compare
benalleng
force-pushed
the
nostr-enhancement
branch
from
8b1538f
to
f4a98f4
Compare
There was a problem hiding this comment.
kind of like what you were saying on our call, I think it the functionality where you click "pay" on a contact and it autopopulates is awesome, the other stuff is more of a symptom of the tag editor being not-great right now. so I'd just do the payee tagging stuff (and keep the disable state for the dropdown list, that's a nice fix) and drop the rest for now
| } | ||
| }); | ||
|
|
||
| const selectProps = createMemo(() => { | ||
| return createOptions(availableTags() || [], { | ||
| key: "name", | ||
| disable: (value) => props.selectedValues.includes(value), |
There was a problem hiding this comment.
this is great thank you
src/components/TagEditor.tsx
Outdated
| @@ -70,10 +80,16 @@ export function TagEditor(props: { | |||
| /> | |||
| <div class="flex flex-wrap gap-2"> | |||
There was a problem hiding this comment.
what if we just drop this whole section? it's supposed to update with recommended tags as you use them, but right now it's just kind of confusing
There was a problem hiding this comment.
Went ahead and completely removed it. maybe we should poll if we want it as is or remove it until the redesign
| @@ -56,6 +56,7 @@ export function ContactViewer(props: { | |||
| showToast(result.error); | |||
| return; | |||
| } else { | |||
| result.value.privateTag = props.contact.name; | |||
There was a problem hiding this comment.
this privateTag thing was a really slick solution
|
Going to correct the scope of this PR, It became sort of a test PR for me to demonstrate some concepts but we are going to move those things explored into #546 as they are more tag function focused. |
benalleng
force-pushed
the
nostr-enhancement
branch
from
ea86f58
to
c6da807
Compare
Testing autofill tags on contact send
Kazam_screencast_00008.webm