add vss config option #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futurepaul
force-pushed
the
vss-configurable
branch
from
514104d
to
d640659
Compare
Deploying with
|
| Latest commit: |
062ee5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8402453.mutiny-web.pages.dev |
| Branch Preview URL: | https://vss-configurable.mutiny-web.pages.dev |
benthecarman
force-pushed
the
vss-configurable
branch
2 times, most recently
from
9410434
to
e17d7fa
Compare
benthecarman
force-pushed
the
vss-configurable
branch
from
e17d7fa
to
8284dda
Compare
TonyGiorgio
requested changes
Sep 28, 2023
TonyGiorgio
reviewed
Sep 28, 2023
TonyGiorgio
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used this opportunity to improve how we handle setup errors outside the main route. before it would hang if error when trying to load
/settings/servers. still not a PERFECT story for if someone puts in a bad url and saves, but they should still be able to nav to settings and fix. I made it so settings doesn't even rely on megastore which should make it extra resilient. could potentially add a link on an error page but would only want to do that if we were confident that's the right move