Correct outbound calculation #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
correct-outbound
branch
from
82318a0
to
6f322e6
Compare
Deploying with
|
| Latest commit: |
6f322e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://144247c9.mutiny-web.pages.dev |
| Branch Preview URL: | https://correct-outbound.mutiny-web.pages.dev |
benalleng
added a commit
to benalleng/mutiny-web
that referenced
this pull request
Sep 28, 2023
|
So this is just applied to the settings page? Currently it's double counting reserve, once in outbound and once in the new reserve balance? |
|
Yeah just on the LN channels page |
benalleng
added a commit
to benalleng/mutiny-web
that referenced
this pull request
Sep 29, 2023
benalleng
added a commit
to benalleng/mutiny-web
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were showing our ln balance as outbound, however for our LN balance we include things like the reserve so it doesn't look like you randomly lose money. This fixes so we actually correctly calculate outbound capacity
Related to #564