Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index html #651

Merged
merged 1 commit into from Nov 2, 2023
Merged

Add index html #651

merged 1 commit into from Nov 2, 2023

Conversation

futurepaul
Copy link
Collaborator

saw on solid discord apparently you can just throw in an index.html to the root and that will get used for static spa builds (what we do)

want to see if this improves our meta data on https://renderform.io/tools/twitter-card-preview-tool/#

@futurepaul
Copy link
Collaborator Author

before:
Screenshot 2023-11-01 at 2 09 30 PM

after:
Screenshot 2023-11-01 at 2 09 13 PM

@benthecarman
Copy link
Collaborator

You have a commit from another pr

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Nov 1, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 755f3fd
Status: ✅  Deploy successful!
Preview URL: https://ea2ee8fa.mutiny-web.pages.dev
Branch Preview URL: https://add-index-html.mutiny-web.pages.dev

View logs

@futurepaul
Copy link
Collaborator Author

@TonyGiorgio you added insertHead.js so want to make sure this is accomplishing what that was... the android app seems to work fine for me in the emulator with this change

@TonyGiorgio
Copy link
Collaborator

Do a full end to end test. Sadly I didn't comment on why it was needed. Might need to search back. It isn't initially needed but I'm pretty sure some things were broken. May I ask why you are removing it?

@futurepaul
Copy link
Collaborator Author

it sounds related to this: https://stackoverflow.com/questions/62125279/what-does-unable-to-inject-capacitor-mean-and-how-can-i-fix-it

all this script does is add a <head></head> tag to the html during the build step so capacitor has a place to inject itself. but now that we have an html file that already has a <head> tag in it I don't think that's necessary?

@TonyGiorgio
Copy link
Collaborator

Perfect, sounds good to me then.

@TonyGiorgio TonyGiorgio merged commit 9186986 into master Nov 2, 2023
4 checks passed
@TonyGiorgio TonyGiorgio deleted the add-index-html branch November 2, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benthecarman benthecarman benthecarman approved these changes

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@futurepaul @benthecarman @TonyGiorgio