Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federations #746

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Federations #746

merged 8 commits into from
Dec 21, 2023

Conversation

TonyGiorgio
Copy link
Collaborator

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Nov 30, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 561d55f
Status: ✅  Deploy successful!
Preview URL: https://8ce60064.mutiny-web.pages.dev
Branch Preview URL: https://update-v0-5-0.mutiny-web.pages.dev

View logs

@TonyGiorgio
Copy link
Collaborator Author

ready for more frontend testing, just without the persistent storage.

Here's a federation invite code on signet: fed11qgqzc2nhwden5te0vejkg6tdd9h8gepwvejkg6tdd9h8garhduhx6at5d9h8jmn9wshxxmmd9uqqzgxg6s3evnr6m9zdxr6hxkdkukexpcs3mn7mj3g5pc5dfh63l4tj6g9zk4er

@TonyGiorgio TonyGiorgio changed the title v0.5 Federations Dec 21, 2023
@TonyGiorgio TonyGiorgio force-pushed the update-v0.5.0 branch 3 times, most recently from 8e6a3a7 to 42f0064 Compare December 21, 2023 22:13
@TonyGiorgio TonyGiorgio marked this pull request as ready for review December 21, 2023 23:03
futurepaul
futurepaul approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm / works on my machine. tested on chrome and in safari on ios and as ios app on device

benthecarman
benthecarman requested changes Dec 21, 2023
View reviewed changes
src/routes/Gift.tsx
Comment on lines +71 to +72
(state.balance?.lightning || 0n) +
(state.balance?.federation || 0n);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are doing this a bunch everywhere, probably a good indication we should add in mutiny-core something like can_pay_lightning(amt) that checks both federation and lightning balance. Good for a follow up though

src/routes/settings/ManageFederations.tsx Outdated Show resolved Hide resolved
src/i18n/en/translations.ts
Comment on lines +547 to +548
description:
"Mutiny has experimental support for the Fedimint protocol. You'll need a federation invite code to use this feature. These funds are currently not backed up remotely. Store funds in a federation at your own risk!",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could note something about rug-pull risk here too, fine for now though

src/routes/settings/ManageFederations.tsx
key={i18n.t("settings.manage_federations.expires")}
>
<time>
{timeAgo(props.fed.federation_expiry_timestamp)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeAgo isn't the best name for this function now since it is returning a future time, but fine for now i guess

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to display a warning or something if the expiration is in the past though

@TonyGiorgio TonyGiorgio merged commit cb09dd7 into master Dec 21, 2023
5 checks passed
@TonyGiorgio TonyGiorgio deleted the update-v0.5.0 branch December 21, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futurepaul futurepaul futurepaul approved these changes

@benthecarman benthecarman benthecarman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TonyGiorgio @futurepaul @benthecarman