Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep Mozart KV525 #1006

Merged
merged 4 commits into from Aug 17, 2018
Merged

Prep Mozart KV525 #1006

merged 4 commits into from Aug 17, 2018

Conversation

glenl
Copy link
Contributor

@glenl glenl commented Aug 4, 2018

  • Added a top folder.
  • Added a version string at the top of the mutopia-header.ily file. (I think there is a template file I need to update because I keep having to do this.)

@chrissawer, needs mupub 1.0.5-beta, mupub build --header=common/mutopia-header.ily --parts-folder=parts

Closes #1004

@glenl
Copy link
Contributor Author

glenl commented Aug 4, 2018

@mikeblackstock please note that I uncommented the definition of condenseRestsin definitions.ily to allow the part scores to build. Please review this and provide a +1 if you wish the publication to be made with this change.

@chrissawer please hold off on publication until reviewed.

@mikeblackstock
Copy link
Contributor

re. "uncommented the definition of condenseRests... Please review this and provide a +1 if you wish the publication to be made with this change."

Sounds good to me! (I'm not sure what "provide a +1" means so I'm just commenting here. Thx.

@glenl
Copy link
Contributor Author

glenl commented Aug 5, 2018

Sounds good to me! (I'm not sure what "provide a +1" means so I'm just commenting here. Thx.

+1 is reviewer-speak for reviewing and accepting the change. Thanks for that.

@chrissawer this piece is ready for publication.

@chrissawer chrissawer merged commit ff1dd24 into MutopiaProject:master Aug 17, 2018
@glenl glenl deleted the prep-mozart-kv525 branch December 11, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants