Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment close does not work if fragment presentation attribute has backstack set to false #2600

Closed
1 of 7 tasks
thefex opened this issue Feb 10, 2018 · 0 comments
Closed
1 of 7 tasks

Fragment close does not work if fragment presentation attribute has backstack set to false #2600

thefex opened this issue Feb 10, 2018 · 0 comments
Labels
p/android Android platform p/android-support Android Support Packages platform t/bug Bug type
Milestone
6.0.0

Comments

@thefex
Copy link
Contributor

thefex commented Feb 10, 2018

Steps to reproduce 📜

  1. Use traditional Mvx fragment flow, but make sure your [MvxFragmentPresentationAttribute] has isBackStack field set to false.

  2. Close viewmodel attached to fragment

  3. Activity is closed instead of fragment.

Expected behavior 🤔

Fragment should be closed.

Actual behavior 🐛

Activity is closed.

Configuration 🔧

Version: most recent nuget + develop branch

Platform:

  • 📱 iOS
  • 🤖 Android
  • 🏁 WPF
  • 🌎 UWP
  • 🍎 MacOS
  • 📺 tvOS
  • 🐒 Xamarin.Forms
thefex pushed a commit to thefex/MvvmCross that referenced this issue Feb 10, 2018
Fragment close does not work if fragment presentation attribute has b…
ef0c5e2 
…ackstack set to false MvvmCross#2600

fix
@nmilcoff nmilcoff added t/bug Bug type p/android Android platform labels Feb 10, 2018
@nmilcoff nmilcoff added this to the 6.0.0 milestone Feb 10, 2018
martijn00 added a commit that referenced this issue Feb 11, 2018
@martijn00
Merge pull request #2601 from thefex/hotfix/fragment_close_does_not_work
20575de 
 #2600 no backstack fragment close does not work hotfix
@nmilcoff nmilcoff added the p/android-support Android Support Packages platform label Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p/android Android platform p/android-support Android Support Packages platform t/bug Bug type
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@thefex @nmilcoff