Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1485 - MvxObservableCollection RemoveRange raises Reset action #1486

Merged
merged 2 commits into from Nov 25, 2016
Merged

Conversation

prin53
Copy link
Member

@prin53 prin53 commented Nov 16, 2016

Fix for #1485

@kjeremy
Copy link
Contributor

kjeremy commented Nov 16, 2016

Is there a way to fix this without forcing a Reset?

@kjeremy
Copy link
Contributor

kjeremy commented Nov 16, 2016

So after staring at this I think Reset is the correct thing to do in this instance of RemoveRange. However there should really be an alternate RemoveRange that works on an actual range (ie contiguous) of elements.

Something like:

  1. RemoveRange(int start, int count) which would remove an actual range from the collection.
  2. Then we should take the current RemoveRange and rename it to something like RemoveItems because the Range name describes the shape of the input and not the operation.

@martijn00 martijn00 merged commit 813ee7e into MvvmCross:develop Nov 25, 2016
@martijn00
Copy link
Contributor

Thanks!

@martijn00 martijn00 added this to the 5.0.0 milestone Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants