Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move routing to mvvmcross source #1595

Merged
merged 9 commits into from Feb 13, 2017
Merged

Move routing to mvvmcross source #1595

merged 9 commits into from Feb 13, 2017

Conversation

martijn00
Copy link
Contributor

Fix for: #1315

@charri can you review this?

@martijn00 martijn00 mentioned this pull request Feb 9, 2017
Closed
22 tasks
@kjeremy
Copy link
Contributor

kjeremy commented Feb 9, 2017

  1. Should the Regexs be compiled? They will potentially be used a lot.
  2. Should we also accept Uri objects since navigation is based on uris?

@kjeremy
Copy link
Contributor

kjeremy commented Feb 9, 2017

Furthermore: how does this interact with things like Android's deep linking : is there a relationship between the two? Can we make one?

@kjeremy
Copy link
Contributor

kjeremy commented Feb 12, 2017

As for my question above I see in the example that you use linking via an IntentFilter so awesome.

kjeremy
kjeremy approved these changes Feb 12, 2017
View reviewed changes
Copy link
Contributor

@kjeremy kjeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and easy to use.

@martijn00 martijn00 merged commit bf3fb22 into MvvmCross:develop Feb 13, 2017
@martijn00 martijn00 mentioned this pull request Feb 14, 2017
Closed
@martijn00 martijn00 deleted the navigation branch February 24, 2017 15:37
@martijn00 martijn00 added this to the 5.0.0 milestone Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjeremy kjeremy kjeremy approved these changes

@Cheesebaron Cheesebaron Awaiting requested review from Cheesebaron

Assignees
No one assigned
Labels
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martijn00 @kjeremy @Cheesebaron