Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null check in Adapter setter #1733

Merged
merged 1 commit into from Apr 26, 2017
Merged

Fix null check in Adapter setter #1733

merged 1 commit into from Apr 26, 2017

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented Apr 26, 2017

We need to guard against existingHeaderFooterAdapter being null

@kjeremy
Copy link
Contributor Author

kjeremy commented Apr 26, 2017

We will need this in 5.0

@Cheesebaron Cheesebaron added the p/android-support Android Support Packages platform label Apr 26, 2017
@Cheesebaron Cheesebaron merged commit 851dd9b into MvvmCross:develop Apr 26, 2017
@martijn00 martijn00 added this to the 5.0.0 milestone Apr 28, 2017
kjeremy added a commit to kjeremy/MvvmCross that referenced this pull request May 1, 2017
@kjeremy
Revert "Fix null check in Adapter setter (MvvmCross#1733)"
e98f75e 
This reverts commit 851dd9b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheesebaron Cheesebaron Cheesebaron approved these changes

Assignees
No one assigned
Labels
p/android-support Android Support Packages platform
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kjeremy @Cheesebaron @martijn00