New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving from Old wiki - Create Customizing using App and Setup #1760
Conversation
Thanks a lot AnthonyNuguna. Can you make sure there is a space between the # header instead of #header and is also missing the frontmatter yaml which you can see at the top in the other docs: https://github.com/MvvmCross/MvvmCross/edit/develop/docs/_documentation/fundamentals/data-binding.md. As a final remark the ```c# should be add before there is a code sample to show it properly as code. For more info check this: https://www.mvvmcross.com/documentation/contribute/mvvmcross-docs-style-guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remarks still, after those it should be good to merge!
|
||
**Note:** for WindowsPhone only, if you load Views from any Assembly other than the main one, then you need to add a MvxPhoneViewAttribute to each of those Views in order to help MvvmCross work out the Xaml Url for the View. For example, if the SpecialLoginView is a Xaml page located in the SubViews folder of the MyOrg.Satellite.ExtraViews assembly then you will need to add the attribute: [MvxPhoneView("/MyOrg.Satellite.ExtraView;component/SubViews/BlockedUsers.xaml")] | ||
|
||
##Overriding ViewModel Location/Construction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs spacing
* simple rule-based IoC registration - e.g.: | ||
|
||
```c# | ||
CreatableTypes() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a default tab space for almost all code examples. Can you remove the first tab? After that it look good to merge
Looks good! Thanks a lot! |
Thanks. |
The wiki is missing from the github project - so moving this to the new documentation area