Add support for all UIControlEvents #1829
Conversation
| base.Dispose(isDisposing); | ||
| } | ||
|
|
||
| private void AddHandler(UIControl control) |
There was a problem hiding this comment.
Can we use WeakEvents instead here?
There was a problem hiding this comment.
I just used the ones that were implemented before. I'm also not 100% sure if WeakEvents will use here as we attach to an existing event handler and we don't replace one.
| @@ -42,7 +42,7 @@ public override void ViewDidLoad() | |||
| var bindingSet = this.CreateBindingSet<CenterPanelView, CenterPanelViewModel>(); | |||
| bindingSet.Bind(label).To(vm => vm.ExampleValue); | |||
| bindingSet.Bind(rightPanelInstructions).To(vm => vm.RightPanelInstructions); | |||
| bindingSet.Bind(masterButton).To(vm => vm.ShowMasterCommand); | |||
| bindingSet.Bind(masterButton).For("TouchDown").To(vm => vm.ShowMasterCommand); | |||
There was a problem hiding this comment.
Can we still have TouchUpInside as default if nothing specificed, such that you don't break all Apps.
There was a problem hiding this comment.
I believe this PR would not affect the default binding for a UIButton. It would just default to the TouchUpInside version of this custom binding.
There was a problem hiding this comment.
@Cheesebaron @Plac3hold3r is right, the default binding is/are not affected.
|
@tritter could you also update the iOS extension method bindings with these additions? As well as the documentation? |
|
@Plac3hold3r just updated the extensions and docs |
It was not possible before to use all possible control events on controls. This limitation made it impossible to use for example the TouchDown event which fires directly on a button touch, which is required in some designs. I added all control events that are possible and merged the current target binders into one MvxUIControlTouchUpInsideTargetBinding.cs