Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Init and Start with Initialize method #1873

Merged

Conversation

mvanbeusekom
Copy link
Contributor

@mvanbeusekom mvanbeusekom commented May 26, 2017

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature - update the MvvmCross Starter Pack code to make use of new MvvmCross 5 features.

I am wondering if I should also already inject the MvxNavigationService into the MainViewModel, it will not be used directly but changes are that most people will do navigation from here. And it will be a nice introduction to the new navigation service.

⤵️ What is the current behavior?

In the current version the generated MainViewModel uses the Init and Start methods to initialise the viewmodel.

🆕 What is the new behavior (if this is a feature change)?

Use the new Initialize method to allow for async support.

💥 Does this PR introduce a breaking change?

Nope (if released with version 5.0.1 or later). Earlier versions don't call Initialize from the AppStart method.

🐛 Recommendations for testing

See breaking change.

📝 Links to relevant issues/docs

none

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

public override void Start()
{
//TODO: Add starting logic here
//TODO: Add starting logic here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing seems odd here

Tabs to spaces

More tabs to spaces
@mvanbeusekom
Copy link
Contributor Author

mvanbeusekom commented May 26, 2017

Those tabs get me every time, apologies. They are corrected. Squashed and forced push changes.

@Cheesebaron Cheesebaron merged commit d3b777d into MvvmCross:develop May 27, 2017
@mvanbeusekom mvanbeusekom deleted the feature/update_starterpack branch May 29, 2017 13:56
@martijn00 martijn00 added this to the 5.0.2 milestone Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants