Replaced Init
and Start
with Initialize
method
#1873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature - update the MvvmCross Starter Pack code to make use of new MvvmCross 5 features.
I am wondering if I should also already inject the
MvxNavigationService
into theMainViewModel
, it will not be used directly but changes are that most people will do navigation from here. And it will be a nice introduction to the new navigation service.In the current version the generated
MainViewModel
uses theInit
andStart
methods to initialise the viewmodel.🆕 What is the new behavior (if this is a feature change)?
Use the new
Initialize
method to allow for async support.💥 Does this PR introduce a breaking change?
Nope (if released with version 5.0.1 or later). Earlier versions don't call
Initialize
from theAppStart
method.🐛 Recommendations for testing
See breaking change.
📝 Links to relevant issues/docs
none
🤔 Checklist before submitting