Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MissingMethodException when using MvxImageView pre-Android API 21 #2011

Merged

Conversation

mvanbeusekom
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

When using the MvxImageView control on Android API 20 and lower (everything before API 21) you'll get a MissingMethodException. This is caused due to the new constructor ImageView(Context context, AttributeSet attrs, int defStyle, int defStyleRes) which was only added in API 21.

🆕 What is the new behavior (if this is a feature change)?

The MissingMethodException is no longer thrown because the new constructor is only called for API 21 and higher.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Create a simple Android application which targets any API lower then 21 and include a MvxImageView control.

📝 Links to relevant issues/docs

The following external references exists:

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • [N/A] Relevant documentation was updated (docs style guide)
  • [N/A] Nuspec files were updated (when applicable)
  • Rebased onto current develop

@martijn00 martijn00 merged commit 6a77153 into MvvmCross:develop Jul 4, 2017
@martijn00 martijn00 added this to the 5.0.6 milestone Jul 4, 2017
@mvanbeusekom mvanbeusekom deleted the feature/missingmethor_mvximageview branch July 4, 2017 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants