Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WPF presenter #2136

Merged
merged 4 commits into from Aug 24, 2017
Merged

Update WPF presenter #2136

merged 4 commits into from Aug 24, 2017

Conversation

jz5
Copy link
Contributor

@jz5 jz5 commented Aug 23, 2017

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

feature and doc

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

Compare to previous 'new preseter'

  • Support IMvxOverridePresentationAttribute
    • This enables easily that multiple window view can show view from same child view class. See WindowView/WindowChildView in plyaground.
  • Support non-stack navigation (default behavior is stack navigation)
    • This enables easily tab like navigation. See WindowView/WindowChildView in playground
  • Accept ContentControl only for the first host view
    • This enables flexible host view. See the followings.
var presenter = new MvxWpfViewPresenter(MainWindow);
// or
var presenter = new MvxWpfViewPresenter(MainWindow.FindName("FooContentControl") as ContentControl);
  • Add overload constructor to MvxWpfSetup (This is not a breaking change)
    • This enables that custom presenter creation in Setup.cs
  • Add doc

💥 Does this PR introduce a breaking change?

  • Yes: For not released 5.2 presenter (presenter of New WPF presenter #2124)
    • protected function signature changed: GetAttributeForViewModel(Type viewModelType) to GetPresentationAttributes(FrameworkElement element) for IMvxOverridePresentationAttribute support
  • Yes: For released 5.1 presenter. (See New WPF presenter #2124)

🐛 Recommendations for testing

📝 Links to relevant issues/docs

#2124

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

@martijn00 martijn00 added this to the 5.2.0 milestone Aug 24, 2017
@martijn00 martijn00 merged commit f038c8e into MvvmCross:develop Aug 24, 2017
@trungklam
Copy link
Contributor

trungklam commented Mar 21, 2018

Sorry for pumping this up with some basic questions, I'm totally a newbie with WPF.
Do we have any sample how we can implement a tab bar navigation with this new WPF presenter ? Currently I already implemented the tab bar navigation for ios app (By using MvxTabPresentation)and want to do the same for WPF but cannot figured out where should I start.

@martijn00
Copy link
Contributor

@Happin3ss don't comment on old PR's. Please open new issues for things you find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants