New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replace root to add safety check to replace it #2291

Merged

martijn00 merged 1 commit into MvvmCross:develop from martijn00:forms-root

Oct 24, 2017

Contributor

martijn00 commented Oct 24, 2017 •

edited

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Fixes #2289

⤵️ What is the current behavior?

Crash when replacing root MainPage.

🆕 What is the new behavior (if this is a feature change)?

Use a Forms trick to replace it.

💥 Does this PR introduce a breaking change?

Should not.

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

All projects build
Follows style guide lines (code style guide)
Relevant documentation was updated (docs style guide)
Nuspec files were updated (when applicable)
Rebased onto current develop


          Add replace root to add safety check to replace it

1eee659

martijn00 added this to the 5.3.3 milestone

nmilcoff approved these changes

View reviewed changes

martijn00 merged commit 82fe470 into MvvmCross:develop

martijn00 deleted the forms-root branch

October 25, 2017 16:24

martijn00 modified the milestones: 5.3.3, 5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment