New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc about linking #2744
Add doc about linking #2744
Conversation
Would "skipping assemblies" be a third option we should add here? |
@nmilcoff I could add that, but in general skipping MvvmCross entirely is no fun 😄 |
I'd say we include it as a last-resource option, since dealing with the linker in "link-all" mode normally takes some time and effort 😬 |
@nmilcoff sure, I'll add it to the doc :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you have any special notes regarding Proguard on Android? I've run into weird issues in the past and had to disable Multidex/Proguard to get things to work. |
@kjeremy special notes, no. Just regular stuff that I could add. Most of the time it just works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
docs
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting