Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc about linking #2744

Merged
merged 2 commits into from Mar 30, 2018
Merged

Add doc about linking #2744

merged 2 commits into from Mar 30, 2018

Conversation

Cheesebaron
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

docs

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@Cheesebaron Cheesebaron added the t/docs Documentation type label Mar 30, 2018
@nmilcoff
Copy link
Contributor

Would "skipping assemblies" be a third option we should add here?

@Cheesebaron
Copy link
Member Author

@nmilcoff I could add that, but in general skipping MvvmCross entirely is no fun 😄

@nmilcoff
Copy link
Contributor

I'd say we include it as a last-resource option, since dealing with the linker in "link-all" mode normally takes some time and effort 😬

@Cheesebaron
Copy link
Member Author

@nmilcoff sure, I'll add it to the doc :)

Copy link
Contributor

@kjeremy kjeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjeremy
Copy link
Contributor

kjeremy commented Mar 30, 2018

Do you have any special notes regarding Proguard on Android? I've run into weird issues in the past and had to disable Multidex/Proguard to get things to work.

@Cheesebaron
Copy link
Member Author

@kjeremy special notes, no. Just regular stuff that I could add. Most of the time it just works.

Copy link
Contributor

@nmilcoff nmilcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@Cheesebaron Cheesebaron merged commit c6ac883 into master Mar 30, 2018
@Cheesebaron Cheesebaron deleted the docs/linking branch March 30, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/docs Documentation type
Development

Successfully merging this pull request may close these issues.

None yet

4 participants