MvxNativeValueConverter and MvxFormsValueConverter for MvvmCross.Forms #3011
Conversation
|
I am not sure how to make the code pass StyleCop - there are other files in the codebase containing multiple classes of the same name, do I have to do something special to allow this? |
MartinZikmund
changed the title
MartinZikmund
changed the title
|
@MartinZikmund can we have at least one example of using this in the playground forms sample |
|
@MartinZikmund ping? I'm keen to get this merged. Can you help with providing an example and seeing if you can resolve the build failure (you might need to rebase) |
|
@nickrandolph Oh sorry, missed this. I will do this first thing tomorrow :-) ! |
MartinZikmund
force-pushed
the
xforms-converters
branch
from
c7dc631
to
9952752
Compare
|
@nickrandolph this PR auto-closed when I had to do revert of bad commit, so I created a new one - #3047 . Very sorry about the complication. |
|
hmmm if the bad commit was just due to pushing a rebase, you should have been able to just rebase again and then force push to clean up (just for future ref) |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
Currently it is not easy to reuse existing
MvxValueConvertersin MvvmCross.Forms projects, as there is no helper class analogous to UWP'sMvxNativeValueConverterthat would act as an adapter between MvvmCross'IMvxValueConverterand Xamarin.Forms'IValueConverter.🆕 What is the new behavior (if this is a feature change)?
MvxNativeValueConverteris an adapter that allows developers reuse existing MvvmCross value converters in their MvvmCross.Forms projects.MvxFormsValueConverteris just a convenience class that specifies theIValueConverter. This can act as the base class for MvvmCross.Forms-only value converters.💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
x
📝 Links to relevant issues/docs
x
🤔 Checklist before submitting