Catch exceptions in ProcessMvxIntentResult and log #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have no way of surfacing a exception thrown in ProcessMvxIntentResult, since this is called as part of Activity.OnActivityResult. Throwing in ProcessMvxIntentResult will lead to an application crash. For now we just catch the exception and log it.
martijn00
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have no way of surfacing a exception thrown
in ProcessMvxIntentResult, since this is called as part of
Activity.OnActivityResult. Throwing in ProcessMvxIntentResult
will lead to an application crash.
For now we just catch the exception and log it.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
App crashes if exception is thrown in ProcessMvxIntentResult
🆕 What is the new behavior (if this is a feature change)?
No crash
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Partially fixes #2134
🤔 Checklist before submitting