Add attribute to show page on iOS #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheesebaron
previously approved these changes
Mar 26, 2019
|
Could we add a sample for this in the Playground? |
martijn00
force-pushed
the
pageviewcontroller
branch
from
cb25729
to
136adb8
Compare
… updated the presenters
…there so we can show them correctly
martijn00
force-pushed
the
pageviewcontroller
branch
from
ab1f117
to
4769722
Compare
Cheesebaron
approved these changes
May 6, 2019
|
Ran the sample, looks pretty good. Nice and easy to use API. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature
The way to show a viewcontroller page inside a UIPageViewController doesn't use the new presenter system.
🆕 What is the new behavior (if this is a feature change)?
Now you can easily do it with the attributes
💥 Does this PR introduce a breaking change?
Yes
🐛 Recommendations for testing
WIP
📝 Links to relevant issues/docs
Fixes #3230
Closes #1403
🤔 Checklist before submitting