Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make attributes only available on netstandard #3419

Merged
merged 1 commit into from Jun 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion MvvmCross.Forms/AssemblyInfoAttributes.cs
@@ -1,6 +1,17 @@
using Xamarin.Forms;
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MS-PL license.
// See the LICENSE file in the project root for more information.

using System.Runtime.CompilerServices;
using Xamarin.Forms;

[assembly: InternalsVisibleTo("MvvmCross.Forms.Platforms.Wpf")]

[assembly: Xamarin.Forms.Internals.Preserve(AllMembers = true)]

#if NETSTANDARD
[assembly: XmlnsPrefix("http://mvvmcross.com/bind", "mvx")]
[assembly: XmlnsDefinition("http://mvvmcross.com/bind", nameof(MvvmCross.Forms.Bindings))]
[assembly: XmlnsDefinition("http://mvvmcross.com/bind", nameof(MvvmCross.Forms.Converters))]
[assembly: XmlnsDefinition("http://mvvmcross.com/bind", nameof(MvvmCross.Forms.Views))]
#endif
Expand Up @@ -49,6 +49,12 @@ private void HandleMyPropertyChanged(object sender, EventArgs e)
var args = e as ItemTappedEventArgs;
if (args == null) return;

if (view?.ItemClick == null)
{
MvxBindingLog.Error($"Error - ItemClick is null in {nameof(MvxListViewItemClickPropertyTargetBinding)}");
return;
}

view.ItemClick.Execute(args.Item);
}

Expand Down
2 changes: 0 additions & 2 deletions MvvmCross.Forms/MvxFormsLog.cs
Expand Up @@ -2,10 +2,8 @@
// The .NET Foundation licenses this file to you under the MS-PL license.
// See the LICENSE file in the project root for more information.

using System.Runtime.CompilerServices;
using MvvmCross.Logging;

[assembly: InternalsVisibleTo("MvvmCross.Forms.Platforms.Wpf")]
Cheesebaron marked this conversation as resolved.
Show resolved Hide resolved
namespace MvvmCross.Forms
{
internal static class MvxFormsLog
Expand Down