Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android RecyclerView Workaround for GridLayoutManager #3598

Merged
merged 3 commits into from Oct 8, 2019

Conversation

dogukandemir
Copy link
Contributor

@dogukandemir dogukandemir commented Oct 8, 2019

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Workaround

⤵️ What is the current behavior?

Sometimes, MvxRecyclerView crashes because of viewholder item inconsistency. In current MvvmCross version, there is MvxGuardedLinearLayoutManager for LinearLayoutManagers but there is no support for GridLayoutManagers.

RecyclerView bug: https://issuetracker.google.com/issues/37007605#c10

🆕 What is the new behavior (if this is a feature change)?

IndexOutOfBoundsExceptions will be ignored.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

📝 Links to relevant issues/docs

#1640

🤔 Checklist before submitting

@dogukandemir dogukandemir requested a review from a team October 8, 2019 06:37
@dogukandemir dogukandemir changed the title MvxGuardedGridLayoutManager added Android RecyclerView Workaround for GridLayoutManager Oct 8, 2019
@Cheesebaron Cheesebaron self-assigned this Oct 8, 2019
@Cheesebaron Cheesebaron added the p/ios iOS platform label Oct 8, 2019
@Cheesebaron Cheesebaron merged commit 068291d into MvvmCross:develop Oct 8, 2019
@martijn00 martijn00 added this to the 6.5.0 milestone Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/ios iOS platform
Development

Successfully merging this pull request may close these issues.

None yet

3 participants