Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BindingEx WPA81 Project to Windows #973

Closed
wants to merge 3 commits into from

Conversation

ryanherman
Copy link

These are all the changes I had to make to get my WPA81 (Windows Phone 8.1 Store App) to allow BindingEx to be added to the project.

@slodge
Copy link
Contributor

slodge commented Apr 30, 2015

Thank for this

I can't merge it instantly because of a few Android changes, and because I'm not sure we want to collapse all the binding functionality down to CrossCore for the WPA81 level...

I know using more assemblies will mean more projects and dlls to track, but it's worth it so that the code on all platforms matches and so that bits of mvx can be reused independently.

This is a great and big first step though :) Thanks!

@ryanherman
Copy link
Author

No problem! Its working perfectly on our wpa81 project. Thank you for giving me the first step o!

@martijn00
Copy link
Contributor

@ryanherman there seems to be a lot of good stuff in here. Could you open some new PR's targeting the 4.0 branch, and separate concerns so it will be easier to merge? Maybe open one PR per type like: UWP(universal), WP8, etc.

@martijn00 martijn00 mentioned this pull request Aug 9, 2015
@martijn00
Copy link
Contributor

Closing this for now. Please open a new pull request targeting the 4.0 branch using the new namespaces if this still needs to be merged.

@martijn00 martijn00 closed this Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants