-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #2
Update #2
Conversation
Hi @deemp! Thanks for your pull request! Looks good for the most part. I added some comments, if you can reply/fix those we can merge it 🙂 |
@Arjan-Zuidema, unfortunately, I don't see your comments |
Just scroll up in this window 🙂 |
Check files changed tab |
This is how comments should look like |
@deemp I added mentions and request changes |
@deemp What is NODE_OPTIONS=--openssl-legacy-provider used for? |
@Arjan-Zuidema, I answered in a review. Is it visible? |
My bad, I didn't submit |
a31252c
to
6fdca5e
Compare
I updated the workflow to use it as an example |
As there are a lot of commits, I guess it'd be better to squash them before merging |
@Arjan-Zuidema , please, have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just added one more thing, if you can fix that we can merge it :)
This reverts commit 34a52af.
Workflows in my fork fail. Will look into it later |
@Arjan-Zuidema , what can be the cause? https://github.com/deemp/purge-cache/actions/runs/5587233430/jobs/10212852447#step:3:23 |
Seems like a permission issue. But I think that should not happen on a GitHub action run. I think this case needs to be handled so the rest of the run will continue. Could you add that in the PR? Just wrap it with a |
This is merged in #3 🚀 |
Hi, @Arjan-Zuidema !
I updated the action a bit: