Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escrow and governance fixes #139

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Escrow and governance fixes #139

merged 2 commits into from
Oct 10, 2018

Conversation

0xdewy
Copy link
Contributor

@0xdewy 0xdewy commented Oct 9, 2018

fixed censorship vulnerability in lockEscrow(). Added changeBroker/fireBroker functionality. Fixed withdraw() in BrokerAssets.sol

PeterMPhillips
PeterMPhillips approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@PeterMPhillips PeterMPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why'd you remove brokerFee from CrowdsaleGenerator? The calculation is still being done, but it isn't being saved anymore

@PeterMPhillips PeterMPhillips merged commit 5915f9c into MyBitFoundation:develop Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterMPhillips PeterMPhillips PeterMPhillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xdewy @PeterMPhillips